Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation to lib/src/index.rs and lib/src/default_index/ #3196

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add documentation to lib/src/index.rs and lib/src/default_index/ #3196

merged 2 commits into from
Mar 14, 2024

Conversation

emesterhazy
Copy link
Contributor

I am reading through the code and trying to add documentation as I go.

emesterhazy
emesterhazy commented Mar 3, 2024
View reviewed changes
lib/src/index.rs Outdated Show resolved Hide resolved
@emesterhazy emesterhazy requested a review from yuja March 3, 2024 03:33
martinvonz
martinvonz reviewed Mar 3, 2024
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our code docs!

lib/src/default_index/composite.rs Outdated Show resolved Hide resolved
lib/src/index.rs Outdated Show resolved Hide resolved
lib/src/index.rs Outdated Show resolved Hide resolved
lib/src/index.rs Outdated Show resolved Hide resolved
lib/src/index.rs Outdated Show resolved Hide resolved
lib/src/default_index/mod.rs Outdated Show resolved Hide resolved
@emesterhazy emesterhazy force-pushed the push-zvunzrxxykow branch 7 times, most recently from 75e7212 to 8bed95c Compare March 5, 2024 18:14
martinvonz
martinvonz reviewed Mar 5, 2024
View reviewed changes
lib/src/index.rs Outdated Show resolved Hide resolved
@emesterhazy emesterhazy force-pushed the push-zvunzrxxykow branch 5 times, most recently from e96ec46 to 7a00e47 Compare March 6, 2024 17:41
martinvonz
martinvonz approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@emesterhazy emesterhazy merged commit f308571 into main Mar 14, 2024
16 checks passed
@emesterhazy emesterhazy deleted the push-zvunzrxxykow branch March 14, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja left review comments

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emesterhazy @yuja @martinvonz